Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missuse of binary expressions #1728

Merged
merged 3 commits into from
Jan 15, 2024

Conversation

Nsttt
Copy link
Contributor

@Nsttt Nsttt commented Jan 15, 2024

There's a few missuses of binary expresions that make them constant evaluations.

This PR fixes them.

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

Fix constant binary expressions.


Screenshots

[Screenshots]

💯

Copy link

changeset-bot bot commented Jan 15, 2024

🦋 Changeset detected

Latest commit: 380ea88

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2024 11:49am

Copy link

vercel bot commented Jan 15, 2024

@Nsttt is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added 📚 documentation Improvements or additions to documentation 📌 area: cli Relates to the CLI labels Jan 15, 2024
Copy link
Contributor

github-actions bot commented Jan 15, 2024

Hey t3-oss/translators!

This PR contains changes to your language. Please review the changes ❤️.

OG.TS:

@Nsttt Nsttt changed the title fix: fix missuse of binary expressions fix: missuse of binary expressions Jan 15, 2024
@juliusmarminge juliusmarminge added this pull request to the merge queue Jan 15, 2024
Merged via the queue into t3-oss:main with commit 06ec5b3 Jan 15, 2024
75 of 76 checks passed
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App 📚 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants